You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On CI execution we see a lot of exceptions logged to output. Given that timeout is 5 seconds only, it is good just to suppress these exceptions even in internal logs.
Motivation and Context
In internal logs output we see:
Starting ChromeDriver 129.0.6668.89 (951c0b97221f8d4ba37cf97d324505c832251cf9-refs/branch-heads/6668@{#1503}) on port 33711
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully on port 33711.
=> OpenQA.Selenium.DevTools.DevToolsNetworkTest
14:07:49.693 TRACE DriverService: System.Net.Http.HttpRequestException: Connection refused (localhost:33711)
---> System.Net.Sockets.SocketException (111): Connection refused
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at OpenQA.Selenium.DriverService.<>c__DisplayClass51_1.<<get_IsInitialized>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at OpenQA.Selenium.DriverService.get_IsInitialized()
14:07:49.759 DEBUG HttpCommandExecutor: Executing command: []: newSession {"capabilities":{"firstMatch":[{"browserName":"chrome","browserVersion":"129","goog:chromeOptions":{"args":["--no-sandbox","--disable-dev-shm-usage"],"binary":"external/_main~pin_browsers_extension~linux_chrome/chrome-linux64/chrome"}}]}}
14:07:49.770 TRACE HttpCommandExecutor: >> POST RequestUri: http://localhost:33711/session, Content: System.Net.Http.ByteArrayContent, Headers: 2
{"capabilities":{"firstMatch":[{"browserName":"chrome","browserVersion":"129","goog:chromeOptions":{"args":["--no-sandbox","--disable-dev-shm-usage"],"binary":"external/_main~pin_browsers_extension~linux_chrome/chrome-linux64/chrome"}}]}}
14:07:50.644 TRACE HttpCommandExecutor: << StatusCode: 200, ReasonPhrase: OK, Content: System.Net.Http.HttpConnectionResponseContent, Headers: 1
14:07:50.654 DEBUG HttpCommandExecutor: Response: (8595a7fcc69f3c9a13e891be7132dbe1 Success: System.Collections.Generic.Dictionary`2[System.String,System.Object])
=> OpenQA.Selenium.DevTools.DevToolsNetworkTest.ByPassServiceWorker
14:07:51.017 DEBUG HttpCommandExecutor: Executing command: [8595a7fcc69f3c9a13e891be7132dbe1]: quit {}
14:07:51.018 TRACE HttpCommandExecutor: >> DELETE RequestUri: http://localhost:33711/session/8595a7fcc69f3c9a13e891be7132dbe1, Content: null, Headers: 2
14:07:51.071 TRACE HttpCommandExecutor: << StatusCode: 200, ReasonPhrase: OK, Content: System.Net.Http.HttpConnectionResponseContent, Headers: 1
14:07:51.071 DEBUG HttpCommandExecutor: Response: ( Success: )
=> OpenQA.Selenium.DevTools.DevToolsNetworkTest.EmulateNetworkConditionOffline
14:07:51.105 TRACE DriverService: System.Net.Http.HttpRequestException: Connection refused (localhost:44883)
---> System.Net.Sockets.SocketException (111): Connection refused
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at OpenQA.Selenium.DriverService.<>c__DisplayClass51_1.<<get_IsInitialized>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at OpenQA.Selenium.DriverService.get_IsInitialized()
14:07:51.108 TRACE DriverService: System.Net.Http.HttpRequestException: Connection refused (localhost:44883)
---> System.Net.Sockets.SocketException (111): Connection refused
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at OpenQA.Selenium.DriverService.<>c__DisplayClass51_1.<<get_IsInitialized>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at OpenQA.Selenium.DriverService.get_IsInitialized()
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
…ice is initialized
On CI execution we see a lot of exceptions logged to output. Given that timeout is 5 seconds only, it is good just to suppress these exceptions even in internal logs.
Use more specific exception types in the catch block
Consider using a more specific exception type instead of the general Exception in the catch block. This can make the error handling more precise and easier to understand.
-catch (Exception ex) when (ex is HttpRequestException || ex is TaskCanceledException)+catch (HttpRequestException ex)+{+ // The exception is expected, meaning driver service is not initialized+}+catch (TaskCanceledException ex)+{+ // The exception is expected, meaning driver service is not initialized+}
Apply this suggestion
Suggestion importance[1-10]: 9
Why: Using more specific exception types in the catch block improves the precision and clarity of error handling, aligning with best practices. This change makes the code easier to understand and maintain.
9
Correct a typo in the comment
Fix the typo in the comment "do noothing" to "do nothing" for better code readability and professionalism.
-// do noothing: the exception is expected, meaning driver service is not initialized+// do nothing: the exception is expected, meaning driver service is not initialized
Apply this suggestion
Suggestion importance[1-10]: 8
Why: Fixing the typo in the comment improves code readability and professionalism. It is a straightforward correction that enhances the clarity of the code documentation.
8
Enhancement
Add a debug log message for exceptions during driver service initialization
Consider adding a debug log message to provide more information about the exception. This can help with troubleshooting without adding unnecessary noise to the trace logs.
catch (Exception ex) when (ex is HttpRequestException || ex is TaskCanceledException)
{
- // do noothing: the exception is expected, meaning driver service is not initialized+ // The exception is expected, meaning driver service is not initialized+ Debug.WriteLine($"Driver service initialization in progress: {ex.GetType().Name}");
}
Apply this suggestion
Suggestion importance[1-10]: 7
Why: Adding a debug log message can aid in troubleshooting without cluttering trace logs, which aligns with the PR's goal of removing unnecessary trace logging. This suggestion enhances the code's maintainability and debugging capability.
…ice is initialized (SeleniumHQ#14557)
* [dotnet] Don't write trace log message when waiting until driver service is initialized
On CI execution we see a lot of exceptions logged to output. Given that timeout is 5 seconds only, it is good just to suppress these exceptions even in internal logs.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
On CI execution we see a lot of exceptions logged to output. Given that timeout is 5 seconds only, it is good just to suppress these exceptions even in internal logs.
Motivation and Context
In internal logs output we see:
Types of changes
Checklist
PR Type
enhancement
Description
Changes walkthrough 📝
DriverService.cs
Suppress trace logging for driver service initialization exceptionsdotnet/src/webdriver/DriverService.cs
initialization.
exceptions.